Skip to content

postmortem 0.4.0#127

Merged
nrbgt merged 15 commits intojupyrdf:devfrom
nrbgt:gh-126-postmortem-040
Sep 1, 2023
Merged

postmortem 0.4.0#127
nrbgt merged 15 commits intojupyrdf:devfrom
nrbgt:gh-126-postmortem-040

Conversation

@nrbgt
Copy link
Copy Markdown
Contributor

@nrbgt nrbgt commented Aug 22, 2023

Checklist

  • the PR target is correct
    • main for postmortem, docs-only fixes, and post-release hot-fixes
    • dev for everything else
  • ran doit lint locally

References

Code changes

User-facing changes

  • n/a

Backwards-incompatible changes

  • n/a

@github-actions
Copy link
Copy Markdown

Try it on ⬅️ ReadTheDocs or Binder ➡️

@nrbgt
Copy link
Copy Markdown
Contributor Author

nrbgt commented Aug 22, 2023

Not sure if it's worth blocking here, but want to do a bit of looking into why our packages aren't reproducible... turns out it's our code, and doesn't generate the same webpack output on a given build on CI vs e.g. my machine.

@nrbgt nrbgt mentioned this pull request Aug 22, 2023
39 tasks
@nrbgt nrbgt marked this pull request as ready for review August 23, 2023 14:43
@nrbgt nrbgt force-pushed the gh-126-postmortem-040 branch from 460f49c to df590e8 Compare August 23, 2023 18:21
@nrbgt nrbgt force-pushed the gh-126-postmortem-040 branch from df590e8 to 160acf5 Compare August 23, 2023 18:35
@nrbgt nrbgt force-pushed the gh-126-postmortem-040 branch from 1ce3092 to 9e2d855 Compare August 23, 2023 19:52
@nrbgt nrbgt force-pushed the gh-126-postmortem-040 branch 3 times, most recently from 0f7d254 to f3e0c5f Compare August 23, 2023 21:05
@nrbgt nrbgt force-pushed the gh-126-postmortem-040 branch from f3e0c5f to a5555be Compare August 23, 2023 21:12
@nrbgt nrbgt force-pushed the gh-126-postmortem-040 branch from 8d238d6 to 692ad29 Compare August 23, 2023 21:28
@nrbgt nrbgt requested review from dfreeman06 and sanbales August 24, 2023 14:46
Copy link
Copy Markdown
Contributor

@sanbales sanbales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no notes...

@nrbgt
Copy link
Copy Markdown
Contributor Author

nrbgt commented Sep 1, 2023

Thanks for the review, handling new audit findings, then will merge.

@nrbgt
Copy link
Copy Markdown
Contributor Author

nrbgt commented Sep 1, 2023

In ~30 minutes, we can also take a look at the released-this-morning ipython 8.15...

@nrbgt nrbgt merged commit 45f98bb into jupyrdf:dev Sep 1, 2023
@nrbgt nrbgt deleted the gh-126-postmortem-040 branch September 1, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants