-
Notifications
You must be signed in to change notification settings - Fork 3
Adding inlineDiffs for unified-cell diffs
#32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
inlineDiffs for unified-cell diffs
| 'Whether to show action buttons for chunk acceptance' | ||
| ) | ||
| }, | ||
| allowInlineDiffs: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's document that new argument in the README.md?
Also maybe we could also add it to the unified-file-diff command? (for file diffs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's document that new argument in the
README.md?
Yes we can :)
Also maybe we could also add it to the
unified-file-diffcommand? (for file diffs)
Yes i also implemented it for unified-file-diff but cannot able to test it as the error comes No editor found for file so i removed the changes for unified-file-diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think unified-file-diff not supports notebook because it worked in .py file but not worked in .ipynb file.
|
@jtpio will we can also add |
README.md
Outdated
| newSource: 'print("Hello, World!")', | ||
| showActionButtons: true | ||
| showActionButtons: true, | ||
| allowInlineDiffs: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we don't need to include that argument in these small examples, especially if the default is false (same for the other example below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
jtpio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
This PR adds
inlineDiffsforunified-celldiffs as a new command argument asallowInlineDiffsBy default it is
falsefor current.Screencast.From.2025-10-30.11-45-47.mp4
allowInlineDiffs#27Additional code to test inlineDiffs in details.