-
Notifications
You must be signed in to change notification settings - Fork 376
Updates To Contribution Documentation #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
Codecov Report
@@ Coverage Diff @@
## main #649 +/- ##
==========================================
+ Coverage 77.79% 77.88% +0.09%
==========================================
Files 110 110
Lines 10465 10405 -60
Branches 1419 1400 -19
==========================================
- Hits 8141 8104 -37
+ Misses 1923 1915 -8
+ Partials 401 386 -15
Continue to review full report at Codecov.
|
|
|
||
| jupyter nbclassic --ServerApp.log_level="CRITICAL" | ||
|
|
||
| The following log levels are supported: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think an extra line is needed here so it renders as a list instead of on the same line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have added an extra line. Let me know if there is anything else.
|
|
||
| jupyter nbclassic --ServerApp.log_level="CRITICAL" | ||
|
|
||
| The following log levels are supported: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The following log levels are supported: | |
| The following log levels are supported: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am using a vs code extension viewing .rst files. Is there any specific extension, I could use or something else that lets me preview the changes. I didn't notice any formatting errors with the extension I am using. Thank you!
|
Great! Thank you! |
|
I think it would be valuable to include instructions on installing a frontend for Jupyter Server; however, I don't think nbclassic is the frontend we want to advertise here since it is a legacy frontend. I suggest we change this to JupyterLab or Notebook v7 (currently in alpha). |

Description
When setting up the local server setup, there is no documentation for connecting the front-end app to the server.
Type of change
CONTRIBUTING.rst has been modified as this contains the server setup instructions for running the server locally. Instructions have been added on the Jupyter extension (nbclassic) required for connecting the server and the front-end app. No information has been removed.
How Has This Been Tested?
Emulation of the entire local sever setup has been done a few times in order record any missing steps and no further issue was found.