Skip to content

Conversation

@alzaar
Copy link

@alzaar alzaar commented Dec 26, 2021

Description

When setting up the local server setup, there is no documentation for connecting the front-end app to the server.

Type of change

CONTRIBUTING.rst has been modified as this contains the server setup instructions for running the server locally. Instructions have been added on the Jupyter extension (nbclassic) required for connecting the server and the front-end app. No information has been removed.

  • This change requires a documentation update

How Has This Been Tested?

Emulation of the entire local sever setup has been done a few times in order record any missing steps and no further issue was found.

@welcome
Copy link

welcome bot commented Dec 26, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2021

Codecov Report

Merging #649 (d19c031) into main (3e78339) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
+ Coverage   77.79%   77.88%   +0.09%     
==========================================
  Files         110      110              
  Lines       10465    10405      -60     
  Branches     1419     1400      -19     
==========================================
- Hits         8141     8104      -37     
+ Misses       1923     1915       -8     
+ Partials      401      386      -15     
Impacted Files Coverage Δ
jupyter_server/services/kernels/kernelmanager.py 80.63% <0.00%> (-2.54%) ⬇️
jupyter_server/utils.py 65.90% <0.00%> (ø)
jupyter_server/traittypes.py 68.64% <0.00%> (+6.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e78339...d19c031. Read the comment docs.

@Zsailer Zsailer self-requested a review December 27, 2021 17:13

jupyter nbclassic --ServerApp.log_level="CRITICAL"

The following log levels are supported:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an extra line is needed here so it renders as a list instead of on the same line

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have added an extra line. Let me know if there is anything else.


jupyter nbclassic --ServerApp.log_level="CRITICAL"

The following log levels are supported:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following log levels are supported:
The following log levels are supported:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using a vs code extension viewing .rst files. Is there any specific extension, I could use or something else that lets me preview the changes. I didn't notice any formatting errors with the extension I am using. Thank you!

@Wh1isper
Copy link
Contributor

Wh1isper commented Jan 26, 2022

Great! Thank you!
I had been debugging with jupyterlab before and was completely unaware of nbclassic

@Zsailer
Copy link
Member

Zsailer commented Feb 16, 2023

I think it would be valuable to include instructions on installing a frontend for Jupyter Server; however, I don't think nbclassic is the frontend we want to advertise here since it is a legacy frontend.

I suggest we change this to JupyterLab or Notebook v7 (currently in alpha).

@Zsailer Zsailer self-assigned this Feb 16, 2023
@alzaar alzaar closed this by deleting the head repository Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants