Refactor touch event listeners to prevent page scrolling on touch move #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated touch event listeners to use passive options and prevent default behavior on touchmove.
Contributor
|
|
Added stopImmediatePropagation to touchmove event.
Refactor touchmove event listener to simplify event handling.
Contributor
Author
|
tested on my tablet, is working as expected! |
Contributor
Author
|
We may want to do the same for the non-offscreen canvas |
martinRenou
reviewed
Dec 10, 2025
| } | ||
| } | ||
| async function sendTouchEvent(event: TouchEvent): Promise<void> { | ||
|
|
Collaborator
There was a problem hiding this comment.
Would you be able to make sure the non-offscreen canvas does that as well?
We may want to refactor a bit to share more logic on this. But maybe not as this PR.
Contributor
Author
There was a problem hiding this comment.
Jeah I can add that later today -- need to go afk for ~2h
Collaborator
There was a problem hiding this comment.
Thanks! I'm in no hurry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated touch event listeners to use passive options and prevent default behavior on touch-events
Needs to be tried on readthedocs once its ready