Skip to content

Conversation

@flagarde
Copy link
Collaborator

@flagarde flagarde commented Jun 11, 2023

@TobiasWallner @certik Fix #259 Please have a try in your platform.

@flagarde
Copy link
Collaborator Author

Sorry for the commits (clang-format autofix) and windows love to force some header inclusion order :(

@TobiasWallner
Copy link
Contributor

I checked it out.
My issue #259, seems to be fixed and the terminal is no longer crashing on my machine.

@flagarde
Copy link
Collaborator Author

@certik Could you do a basic test om mac ? In linux it is fixed too :)

@TobiasWallner
Copy link
Contributor

TobiasWallner commented Jun 13, 2023

Enter not working in kilo editor.
As well as ,;.:-_#'+*``?

@flagarde
Copy link
Collaborator Author

@TobiasWallner ok thx for the test I will jave a look

@flagarde
Copy link
Collaborator Author

@TobiasWallner Should be fixed but I will have to dig more into it in the future

@TobiasWallner
Copy link
Contributor

Hi, sry for the late reply, had lots of things to do.
Had a look inside your UTF8 just now and I cannot reproduce the strange error any more, where some characters would not be printed any more.
It seems like everything is working as it should.

@TobiasWallner
Copy link
Contributor

Just to clear things up. Are you returning the key in utf8 or utf32?

@flagarde
Copy link
Collaborator Author

Keys are read/converted to utf8 (windows) store as codepoint (utf32) and send back to terminal as utf8

@flagarde flagarde merged commit 09aefe8 into jupyter-xeus:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: cpp-terminal crashes if two utf8 are inserted simultaneously

2 participants