Initial version with example #1
Conversation
src/index.ts
Outdated
There was a problem hiding this comment.
The view model should not know about the view. What's the intent of this relationship?
There was a problem hiding this comment.
Codemirror has an .on("change",...) event which is re-emitted here as a phosphor-signal. The view-model connects to that signal, so requires a handle on the view (at least temporarily).
There was a problem hiding this comment.
That's not the responsibility of the view model. That connection should be handled in the view, and converted to a method call on the view model. i.e. move the timer to the widget.
|
I'm not sure separating model and view model in this case makes a lot of sense. I think we can combine |
src/index.ts
Outdated
There was a problem hiding this comment.
If you want to make this is an interface (and I don't think we should) it needs to be interface IEditorWidget extends Widget
README.md
Outdated
There was a problem hiding this comment.
this is not a supported runtime - Node doesn't have a DOM.
There was a problem hiding this comment.
I would double check the rest of the README to make sure it's accurate.
|
ping @Carreau |
|
We need your input on what you think an |
|
@dwillmer LGTM for a first cut (modulo comments). I'm assuming we'll iterate on this. |
|
ping @jasongrout You seem to have done some interface work for input area/editor. I think you and Dave should sync up. |
Initial version with example
add github-flavored markdown to the modes the bundler will pick up automatically
4 participants
No description provided.