Working on using actions for menu.

[Carreau]

Mostly for now to be sure that for all menu item there is
a corresponding action.

So that some menu actions are available from command palette.
We can work on auto-generating menus after.

Note to myself. AVAILABLE ONLY HAVE ONE L, get that in your head.

[ellisonbg]

Pinging @sccolbert and @dwillmer on this. Chris and David - here is the work Matthias has been doing to start to use the existing action system in our menus.

[Carreau]

Note, this is a rewriting from scratch of ipython/ipython#7285
there is no technical challenges here, it's just using one extra level of abstraction instead of direct callback binding, just to make sure all actions we use in menus exists.

[minrk]

👍 to this. I like using the actions stuff (except the help-index part). I'm happy to rebase #400 on this one after I test it a bit.

[Carreau]

Rebased, not tested.

[Carreau]

Manually tested, seem to work.

Ping @minrk who worked on these file recently

[Carreau]

Rebased.

[jdfreder]

Haha, had to lookup IIFE acronym - also, probably don't want "F-you" in the comment, even though I totally agree, it's super annoying!

[Carreau]

Wha't the problem with Frickin-you Javascript ?

[jdfreder]

I noticed you left a few of the menu things as non-actions. Would you want to go ahead and convert them all to actions in this PR? Or in a later PR?

[Carreau]

Or in a later PR?

Later PR easier to test manually in an exaustive manner at every rebase.

[Carreau]

Rebased once more. @jdfreder ?

[Carreau]

I now pass event in here.

[minrk]

for-in always needs Object.hasOwnProperty because js is the best.

[minrk]

Actually, I think Object.keys(id_actions_dict) works, too.

[jdfreder]

This is looking great, after you address Min's comments - I think this is good to go!

[Carreau]

Done:

-        for(var idx in id_actions_dict){
+        var keys = Object.keys(id_actions_dict);
+        for(var i in keys){
+            var idx = keys[i];

[minrk]

Sorry. for(...in) is just never safe. It might as well not exist. You have to use

Object.keys(obj).map(function (key) {...});

or filter on obj.hasOwnProperty(key).

some illustration

[Carreau]

        for(var idx in id_actions_dict){
+            if (!id_actions_dict.hasOwnProperty(idx)){
+                continue;
+            }
             var id_act = id_actions_dict[idx];

Better ?

[minrk]

@Carreau yup. I apologize on behalf of Javascript.

[Carreau]

I apologize on behalf of Javascript.

No need to.

Thanks !

[coveralls]

Changes Unknown when pulling 552a5a0 on Carreau:action-menu into ** on jupyter:master**.