Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"author": "Jay Ahn, Kiran Pinnipati",
"files": [
"lib/**/*.{d.ts,eot,gif,html,jpg,js,js.map,json,png,svg,woff2,ttf}",
"style/**/*.{css,eot,gif,html,jpg,json,png,svg,woff2,ttf}"
"style/**/*.{css,eot,gif,html,jpg,json,png,svg,woff2,ttf}",
"schema/*.json"
],
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down Expand Up @@ -43,7 +44,6 @@
"@jupyterlab/application": "^2.1.2",
"@jupyterlab/apputils": "^2.2.4",
"@jupyterlab/cells": "^2.2.4",
"@jupyterlab/coreutils": "^4.1.0",
"@jupyterlab/docmanager": "^2.1.2",
"@jupyterlab/docregistry": "^2.1.2",
"@jupyterlab/fileeditor": "^2.1.2",
Expand Down Expand Up @@ -77,7 +77,8 @@
"style/*.css"
],
"jupyterlab": {
"extension": true
"extension": true,
"schemaDir": "schema"
},
"husky": {
"hooks": {
Expand Down
15 changes: 15 additions & 0 deletions schema/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"jupyter.lab.shortcuts": [
{
"command": "codeSnippet:save-as-snippet",
"keys": ["Accel Shift A"],
"selector": ".jp-Cell"
},
{
"command": "codeSnippet:save-as-snippet",
"keys": ["Accel Shift A"],
"selector": ".jp-FileEditor"
}
],
"type": "object"
}
29 changes: 21 additions & 8 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import {
ILayoutRestorer
} from '@jupyterlab/application';
import { ICommandPalette, WidgetTracker } from '@jupyterlab/apputils';
import { ISettingRegistry } from '@jupyterlab/settingregistry';

import { IEditorServices } from '@jupyterlab/codeeditor';
import { LabIcon } from '@jupyterlab/ui-components';

Expand All @@ -23,6 +25,7 @@ import {

const CODE_SNIPPET_EXTENSION_ID = 'code-snippet-extension';

const CODE_SNIPPET_SETTING_ID = 'jupyterlab-code-snippets:settings';
/**
* Snippet Editor Icon
*/
Expand Down Expand Up @@ -150,7 +153,7 @@ function activateCodeSnippet(
});

//Add an application command
const saveCommand = 'save as code snippet';
const saveCommand = 'codeSnippet:save-as-snippet';
const toggled = false;
app.commands.addCommand(saveCommand, {
label: 'Save As Code Snippet',
Expand All @@ -169,18 +172,16 @@ function activateCodeSnippet(
}
});

//Put the command above in context menu
// Put the saveCommand above in context menu
app.contextMenu.addItem({
command: saveCommand,
selector: '.jp-Cell'
});

// Add keybinding to save
app.commands.addKeyBinding({
// Put the saveCommand in non-notebook file context menu
app.contextMenu.addItem({
command: saveCommand,
args: {},
keys: ['Accel Shift S'],
selector: '.jp-Cell'
selector: '.jp-FileEditor'
});

// Track and restore the widget state
Expand Down Expand Up @@ -211,6 +212,18 @@ function activateCodeSnippet(
});
}

const codeSnippetExtensionSetting: JupyterFrontEndPlugin<void> = {
id: CODE_SNIPPET_SETTING_ID,
autoStart: true,
requires: [ISettingRegistry],
activate: (app: JupyterFrontEnd, settingRegistry: ISettingRegistry) => {
void settingRegistry
.load(CODE_SNIPPET_SETTING_ID)
.then(_ => console.log('settingRegistry successfully loaded!'))
.catch(e => console.log(e));
}
};

function getSelectedText(): string {
let selectedText;
// window.getSelection
Expand All @@ -224,4 +237,4 @@ function getSelectedText(): string {
return selectedText.toString();
}

export default code_snippet_extension;
export default [code_snippet_extension, codeSnippetExtensionSetting];