Skip to content

Conversation

@cronan03
Copy link
Collaborator

@cronan03 cronan03 commented Jul 30, 2024

Add mandatory GSoC report to README as it is set as the source of that report - I (@fcollonval) discovered to late some of the requirements so we cannot change the file as the link is frozen in GSoC evaluation database.

cronan03 added 2 commits July 30, 2024 20:54
final changes as per GSOC requirements
@fcollonval fcollonval added the documentation Improvements or additions to documentation label Jul 31, 2024
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cronan03

I have minor points - mainly typos.

cronan03 and others added 8 commits July 31, 2024 18:13
Co-authored-by: Frédéric Collonval <frederic.collonval@webscit.com>
Co-authored-by: Frédéric Collonval <frederic.collonval@webscit.com>
Co-authored-by: Frédéric Collonval <frederic.collonval@webscit.com>
Co-authored-by: Frédéric Collonval <frederic.collonval@webscit.com>
Co-authored-by: Frédéric Collonval <frederic.collonval@webscit.com>
Co-authored-by: Frédéric Collonval <frederic.collonval@webscit.com>
Co-authored-by: Frédéric Collonval <frederic.collonval@webscit.com>
Copy link
Collaborator Author

@cronan03 cronan03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fcollonval , the changes have been addressed

@fcollonval fcollonval enabled auto-merge (squash) July 31, 2024 15:59
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cronan03

@fcollonval fcollonval merged commit 58146d8 into main Jul 31, 2024
@fcollonval fcollonval deleted the cronan03-patch-1 branch July 31, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants