Pass on themeChanged boolean to cockle #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #62 to pass on optional
isDarkModeboolean to cockle'sthemeChanged. Support for this was added in jupyterlite/cockle#232 and released in cockle 1.0.0.It can be confirmed that this is working in the browser's console. A terminal theme change to something other than
inheritdoes not have this boolean so cockle has to check if the terminal background color is dark and it reports this in the console via:When the terminal theme is
inheritand the JupyterLite theme is changed to one of the default themes such asJupyterLab DarkorJupyterLab Lightthen it knows if it is dark mode and hence no such line is written to the console.