feat(debit_routing): Add support for 6-digit BIN fallback if 8-digit lookup returns empty records#118
Merged
Merged
Conversation
…lookup returns empty records
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds fallback logic to handle 6-digit BIN lookups when 8-digit BIN lookups return empty records in the co-badged card information retrieval process. The changes improve error handling and add logging to track when fallback occurs.
Key changes:
- Added fallback mechanism to retry with 6-digit BIN when 8-digit lookup returns no records
- Improved logging with info messages for fallback scenarios and debug messages for successful retrievals
- Refactored error handling to streamline the control flow and reduce nested match statements
jagan-jaya
requested changes
Jul 18, 2025
jagan-jaya
approved these changes
Jul 18, 2025
prajjwalkumar17
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
get_co_badged_cards_infofunction insrc/decider/network_decider/co_badged_card_info.rsto improve error handling, enhance logging, and streamline the logic for fetching and processing co-badged card information. The changes primarily focus on retrying with a shorter BIN length when no records are found, improving readability, and reducing redundant code.