Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces configuration updates to support extended card bin tracking and adds a new card-related enum to the routing configuration. The changes focus on enhancing the granularity of payment and card processing logic through new configuration fields in config/development.toml.
Key changes:
- Added
extended_card_binstring value field for extended card bin tracking (line 98) - Introduced a new
cardenum with values "debit, credit" (line 80)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several configuration updates to support new card-related fields and types, and introduces a minor formatting change in the routing rules handler. The most significant changes are the addition of new enums and string values for card data in the
config/development.tomlfile, which will help with more granular payment and card processing logic.Card-related configuration enhancements:
cardenum with valuesdebitandcredittoconfig/development.tomlfor better card type distinction.extended_card_binstring value toconfig/development.tomlto support extended card bin tracking.Code formatting:
routing_createfunction insrc/euclid/handlers/routing_rules.rs.