Skip to content

fix(dynamodb-local): fix check on inMemory to allow setting dbPath#647

Merged
shivaraj-bh merged 1 commit intojuspay:mainfrom
attilaersek:bugfix/dynamodb-local-dbpath
Mar 10, 2026
Merged

fix(dynamodb-local): fix check on inMemory to allow setting dbPath#647
shivaraj-bh merged 1 commit intojuspay:mainfrom
attilaersek:bugfix/dynamodb-local-dbpath

Conversation

@attilaersek
Copy link
Copy Markdown
Contributor

What changed?
Adjusted the check in the dynamodb-local service so that the inMemory flag and dbPath setting are evaluated correctly.
Added appropriate test(s) to cover both modes and ensure dbPath can be set when inMemory = false.

@shivaraj-bh shivaraj-bh merged commit cac0961 into juspay:main Mar 10, 2026
4 checks passed
@shivaraj-bh
Copy link
Copy Markdown
Member

Not a concern of this PR, but it occurred to me while reviewing that: asserting in inMemory option with (dbPath) cross-option reference felt a bit awkward. Maybe a NixOS module style assertions option (example) would be nice in such cases. Though straightforward, not enough cases to add support yet; I will re-visit later.

@shivaraj-bh
Copy link
Copy Markdown
Member

Not a concern of this PR, but it occurred to me while reviewing that: asserting in inMemory option with (dbPath) cross-option reference felt a bit awkward. Maybe a NixOS module style assertions option (example) would be nice in such cases. Though straightforward, not enough cases to add support yet; I will re-visit later.

(Created #660 to track)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants