Merged
Conversation
The previous fix split all string parts on whitespace, which incorrectly split paths like "bucket/key" into separate tokens. Now properly tokenizes by treating only whitespace as delimiters while preserving non-whitespace characters (like "/") that should be concatenated with adjacent values. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Extracted tokenizeCommand as a testable function and added 16 test cases covering various scenarios including concatenated values, multiple interpolations, special characters, and real-world usage patterns. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
just-be-dev | 48fe0df | Commit Preview URL Branch Preview URL |
Feb 02 2026, 06:38 AM |
Replaced complex template literal tokenization with a simple variadic function that takes string arguments. This is more explicit, easier to understand, and lets callers do their own string concatenation when needed. Updated all call sites and tests to use the new simpler approach. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
just-be-dev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, the last PR did fix some things, but the tokenization of the command wasn't working out that well. It was too clever, so I just dropped the template string function and passed the args as args. Problem solved?
AI Summary
The initial fix in #201 addressed the basic tokenization issue but incorrectly split non-whitespace characters like
/that appear between template literal values. This caused commands liker2 object put bucket/keyto be tokenized as three separate arguments instead of one concatenated path.This PR improves the tokenization algorithm to properly handle concatenated values by treating only whitespace as token delimiters. Non-whitespace characters adjacent to interpolated values are now correctly concatenated together.
Changes include extracting the logic into a testable
tokenizeCommandfunction and adding 16 comprehensive test cases covering edge cases like paths with slashes, multiple concatenations, special characters, and real-world usage patterns from the deploy script.