services: Add custom labels for to-client mode case.#5
Open
mjtrangoni wants to merge 1 commit intojust1689:mainfrom
Open
services: Add custom labels for to-client mode case.#5mjtrangoni wants to merge 1 commit intojust1689:mainfrom
mjtrangoni wants to merge 1 commit intojust1689:mainfrom
Conversation
This is useful for selecting services for special purposes like monitoring. Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @just1689,
This PR adds a new feature for adding custom labels to the client services. In my case, I need this for monitoring the services with the blackbox_exporter.
Let me know if this is enough or should be extended for other usecases.
Thank you!
Mario