[🐛]: Module breaks consumer queue runner

[edward-simpson]

What is the current behavior?

Consumer queue runner errors with the following:

Warning: Undefined array key "queue_name"

From the file vendor/justbetter/magento2-sentry/Plugin/Profiling/QueuePlugin.php:53:

                'messaging.queue.name'          => $properties['queue_name'],

Funnily enough I noticed this because the module reported itself to sentry :D

What is the expected behavior?

Consumer queue should not error

How can we reproduce the issue?

No response

What is the proposed solution?

Review what exists in the $properties array, maybe the name property has changed key

do you have any additional information for us?

No response

Is there an existing issue for this?

• I have searched the existing issues

Are you willing to create a pull request for this?

• If i have a fix i would be willing to create a pull request

[indykoning]

It seems that queueing engines are not built the same with some lacking some of the fields.
Are you running AMQP by chance?

Could you give #221 a try and let me know if that fixes the issue.
Comparing what Magento adds, and what the underlying package adds queue_name and retries could be missing. The others should always be available 🙂

[edward-simpson]

Yes we're running AMQP

Haven't tried it but it will work - I added a composer patch to ?? '' each array access in that fn (overkill I know but was playing it safe), and that fixed the queue runner

[edward-simpson]

While I'm here, not sure if you want me to open another issue for this or not?

Sentry\Tracing\SpanContext::setDescription(): Argument #1 ($description) must be of type ?string, int given, called in vendor/justbetter/magento2-sentry/Plugin/Profiling/Cache.php on line 34

[edward-simpson]

Looks like it's relating to ShipperHQ caching with a key generated using crc32

[indykoning]

Ah yes, Magento not having strict types really helps 😅
While ususally this should be a separate issue and separate PR i'm gonna break my own rules a little because it's such a small change.
I've updated the PR with the typecast for the description 😁

[edward-simpson]

Fantastic thanks!