Add replyTo to message and mandrill mailer#6
Merged
aprokopenko merged 3 commits intojustcoded:masterfrom Jul 31, 2018
Merged
Conversation
aprokopenko
requested changes
Jul 24, 2018
Contributor
aprokopenko
left a comment
aprokopenko
left a comment
There was a problem hiding this comment.
Please update code according to comments
and
please add ReplyTo header to PHPMailer implementation as well
src/Mailer/MandrillMailer.php
Outdated
| if (0 < $message->getAttachmentsSize() && $message->getAttachmentsSize() < $this->attachmentsSizeLimit | ||
| && $attachments = $message->getAttachments() | ||
| ) { | ||
| if (0 < $message->getAttachmentsSize() && $message->getAttachmentsSize() < $this->attachmentsSizeLimit && $attachments = $message->getAttachments()) { |
Contributor
There was a problem hiding this comment.
please return back previous formatting. the line is too big.
src/Mailer/MandrillMailer.php
Outdated
| 'subject' => $message->getSubject(), | ||
| 'from_email' => $message->getFrom()->getEmail(), | ||
| 'from_name' => $message->getFrom()->getName(), | ||
| 'headers' => ['Reply-To' => $message->getReplyTo()->getEmail()], |
Contributor
There was a problem hiding this comment.
you should check for !empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.