-
Notifications
You must be signed in to change notification settings - Fork 11
feat(pie-breadcrumb): DSW-2831 implement scrim and default variants and implement isCompact mode #2314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ation items and separator
…nd enhanced rendering logic
…-items-and-separation
…ved listitem role to li element
…s to support text truncation
…ontaining large label
…-items-and-separation
🦋 Changeset detectedLatest commit: a0c2414 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
/test-aperture |
|
Starting a new snapshot build. You can view the logs here. |
|
@thejfreitas Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/pie-breadcrumb@0.0.0-snapshot-release-20250404172537 --mode=update-lockfileyarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250404172537 --mode=update-lockfileThen finally: yarn install |
…-items-and-separation
…separation' into dsw-2831-implement-back-and-default-variants
raoufswe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see #2314 (comment) and let me know if you need any help with that 🤞
Please refer the design docs which I scoped this pattern which is clear that variations are default and scrim: https://www.figma.com/design/pPSC73rPin4csb8DiK1CRr/branch/46d9YJsbVPA9fEuC5C2EuT/%E2%9C%A8--Core--Web-Components--PIE-3-?node-id=21145-12749&m=dev This kind of thing should be picked on the refinement phase and if I follow your suggestion, should we change the design docs as well? |
apps/pie-storybook/stories/testing/pie-breadcrumb.test.stories.ts
Outdated
Show resolved
Hide resolved
|
/snapit |
|
Starting a new snapshot build. You can view the logs here. |
|
@raoufswe Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/pie-breadcrumb@0.0.0-snapshot-release-20250429143843 --mode=update-lockfileyarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250429143843 --mode=update-lockfileThen finally: yarn install |
Added
defaultvariant andbackvariant. Thebackvariant will render only the last item fromitemsprop.Added
scrimprop. The Scrim mode will enhance the contrast of the breadcrumb and change the background color, navigation items and separators.Author Checklist (complete before requesting a review, do not delete any)
PIE Storybook/PIE DocsPR preview./test-aperturecommand.Not-applicable Checklist items
Please move any Author checklist items that do not apply to this pull request here.
Testing
How do I test my changes?
Reviewer checklists (complete before approving)
Mark items as
[-] N/Aif not applicable.Reviewer 1 - @jamieomaguire
PIE Storybook/PIE DocsPR preview.Reviewer 2 - @fernandofranca
PIE Storybook/PIE DocsPR preview.