Skip to content

Conversation

@thejfreitas
Copy link
Member

@thejfreitas thejfreitas commented Apr 8, 2025

  • Adds a z-index CSS property to allow users to control the stacking order of the toast component.

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • I have filled out the DS Review Tracker checklist (Moving PR to "Ready to Review")

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1 @fernandofranca

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • N/A If there are visual test updates, I have reviewed them.

Reviewer 2 - @jamieomaguire

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@thejfreitas thejfreitas self-assigned this Apr 8, 2025
@thejfreitas thejfreitas requested review from a team as code owners April 8, 2025 19:12
@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025

🦋 Changeset detected

Latest commit: 9fd611a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@justeattakeaway/pie-toast-provider Minor
pie-storybook Minor
pie-docs Minor
@justeattakeaway/pie-webc Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thejfreitas

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@pie-design-system-bot

This comment was marked as outdated.

@raoufswe raoufswe changed the title feat(pie-toast-provider) DSW-2949 implement zIndex into toast provider feat(pie-toast-provider): DSW-2949 implement zIndex into toast provider Apr 9, 2025
Copy link
Contributor

@fernandofranca fernandofranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! 🔥🔥🔥

@raoufswe

This comment was marked as outdated.

@jamieomaguire
Copy link
Contributor

@thejfreitas I understand your reasoning but I personally feel that a property is overkill even if it is just 10 lines. I think the CSS variable pattern is the most browser-friendly approach as documented by Carbon - I don't think it would be difficult to clearly document what CSS variables can be exposed for overriding by consumers.

Furthermore, doing it here would help us define a pattern to use in other components going forward. For every property we add, its not just about the lines of code but the reactivity and obseriving of a property for changes at runtime.

I am not very familiar with Styled components, but the CSS variable does not necessarily have to be defined in a style attribute on the component. Is there truly no way in Styled components to define arbitrary CSS rules?

Happy to chat offline if easier!

@raoufswe raoufswe requested a review from a team as a code owner April 22, 2025 16:49
@raoufswe raoufswe self-assigned this Apr 23, 2025
@raoufswe
Copy link
Member

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@raoufswe Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/pie-toast-provider@0.0.0-snapshot-release-20250423095841 --mode=update-lockfile
yarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250423095841 --mode=update-lockfile

Then finally:

yarn install

@raoufswe raoufswe merged commit 3cb641e into main Apr 25, 2025
41 of 49 checks passed
@raoufswe raoufswe deleted the dsw-2949-implement-zindex-and-offset-into-toast-provider branch April 25, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants