-
Notifications
You must be signed in to change notification settings - Fork 11
feat(pie-toast-provider): DSW-2949 implement zIndex into toast provider #2317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie-toast-provider): DSW-2949 implement zIndex into toast provider #2317
Conversation
🦋 Changeset detectedLatest commit: 9fd611a The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
fernandofranca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! 🔥🔥🔥
packages/components/pie-toast-provider/test/component/pie-toast-provider.spec.ts
Outdated
Show resolved
Hide resolved
packages/components/pie-toast-provider/test/component/pie-toast-provider.spec.ts
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
|
@thejfreitas I understand your reasoning but I personally feel that a property is overkill even if it is just 10 lines. I think the CSS variable pattern is the most browser-friendly approach as documented by Carbon - I don't think it would be difficult to clearly document what CSS variables can be exposed for overriding by consumers. Furthermore, doing it here would help us define a pattern to use in other components going forward. For every property we add, its not just about the lines of code but the reactivity and obseriving of a property for changes at runtime. I am not very familiar with Styled components, but the CSS variable does not necessarily have to be defined in a Happy to chat offline if easier! |
|
/test-aperture |
|
Starting a new snapshot build. You can view the logs here. |
|
@raoufswe Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/pie-toast-provider@0.0.0-snapshot-release-20250423095841 --mode=update-lockfileyarn up @justeattakeaway/pie-webc@0.0.0-snapshot-release-20250423095841 --mode=update-lockfileThen finally: yarn install |
Author Checklist (complete before requesting a review, do not delete any)
PIE Storybook/PIE DocsPR preview./test-aperturecommand.Not-applicable Checklist items
Please move any Author checklist items that do not apply to this pull request here.
Testing
How do I test my changes?
Reviewer checklists (complete before approving)
Mark items as
[-] N/Aif not applicable.Reviewer 1 @fernandofranca
PIE Storybook/PIE DocsPR preview.Reviewer 2 - @jamieomaguire
PIE Storybook/PIE DocsPR preview.