-
Notifications
You must be signed in to change notification settings - Fork 11
feat(pie-list-item): DSW-2910 base list item #2326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
f44a0b0 to
5bd4bec
Compare
a2ce6fc to
b7d91b7
Compare
Implements the basic structure for pie-list-item component. Includes TypeScript definitions, LitElement class, and React types. Updates vite config to build pie-list-item separately.
Add TODO comment and eslint-disable for empty interface Prepare for future implementation of ListItemProps Maintain code structure for upcoming component development
b7d91b7 to
d8883ee
Compare
Describe your changes (can list changeset entries if preferable)
This PR adds the new pie-list-item component to the PIE Design System with the following structure:
Component Definition: Creates a basic PieListItem class that extends LitElement
TypeScript Types:
An empty ListItemProps interface (with a TODO comment for future implementation)
React typings through ReactBaseType
Web Component Registration:
Registers custom element with tag name pie-list-item
Sets up proper TypeScript definitions for HTML element map
Build Configuration: Updates Vite config to build the component as a separate module
File Structure: Properly organized under the src/pie-list-item/ directory
The PR effectively creates a minimal skeleton for the pie-list-item component, setting up the necessary structure and build configuration, but doesn't yet implement any actual functionality or styling. It's intended as a foundation for further development of the component.
Author Checklist (complete before requesting a review, do not delete any)
(https://github.com/justeattakeaway/pie-aperture/) using the
/test-aperturecommand.Not-applicable Checklist items
Please move any Author checklist items that do not apply to this pull request here.
PIE Storybook/PIE DocsPR preview.Testing
How do I test my changes?
Reviewer checklists (complete before approving)
Mark items as
[-] N/Aif not applicable.Reviewer 1 @raoufswe
PIE Storybook/PIE DocsPR preview.Reviewer 2 @siggerzz
PIE Storybook/PIE DocsPR preview.