Skip to content

Conversation

@matthewhardern
Copy link
Contributor

@matthewhardern matthewhardern commented Apr 15, 2025

Describe your changes (can list changeset entries if preferable)

This PR adds the new pie-list-item component to the PIE Design System with the following structure:

Component Definition: Creates a basic PieListItem class that extends LitElement
TypeScript Types:

An empty ListItemProps interface (with a TODO comment for future implementation)
React typings through ReactBaseType

Web Component Registration:

Registers custom element with tag name pie-list-item
Sets up proper TypeScript definitions for HTML element map

Build Configuration: Updates Vite config to build the component as a separate module
File Structure: Properly organized under the src/pie-list-item/ directory

The PR effectively creates a minimal skeleton for the pie-list-item component, setting up the necessary structure and build configuration, but doesn't yet implement any actual functionality or styling. It's intended as a foundation for further development of the component.

Author Checklist (complete before requesting a review, do not delete any)

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.

  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in [PIE Aperture]

Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1 @raoufswe

  • [-] I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] I have reviewed the Aperture changes (if added)
  • [-] If there are visual test updates, I have reviewed them.

Reviewer 2 @siggerzz

  • [-] I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] I have reviewed the Aperture changes (if added)
  • [-] If there are visual test updates, I have reviewed them.

@changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2025

⚠️ No Changeset found

Latest commit: d8883ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matthewhardern matthewhardern marked this pull request as ready for review April 16, 2025 08:54
@matthewhardern matthewhardern requested review from a team as code owners April 16, 2025 08:54
@matthewhardern matthewhardern changed the title DSW-2910 Base list item DSW-2910 base list item Apr 16, 2025
@matthewhardern matthewhardern changed the title DSW-2910 base list item feat(pie-list-item): DSW-2910 base list item Apr 22, 2025
@matthewhardern matthewhardern force-pushed the dsw-2910-base-list-item branch from f44a0b0 to 5bd4bec Compare April 22, 2025 06:49
@matthewhardern matthewhardern force-pushed the dsw-2910-base-list-item branch from a2ce6fc to b7d91b7 Compare April 22, 2025 10:00
matthew.hardern added 4 commits April 22, 2025 11:00
Implements the basic structure for pie-list-item component.
Includes TypeScript definitions, LitElement class, and React types.
Updates vite config to build pie-list-item separately.
Add TODO comment and eslint-disable for empty interface
Prepare for future implementation of ListItemProps
Maintain code structure for upcoming component development
@matthewhardern matthewhardern force-pushed the dsw-2910-base-list-item branch from b7d91b7 to d8883ee Compare April 22, 2025 10:02
@matthewhardern matthewhardern merged commit a0115df into main Apr 23, 2025
31 of 36 checks passed
@matthewhardern matthewhardern deleted the dsw-2910-base-list-item branch April 23, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants