Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d150fa80d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| deps.flushAssistantTextDelta({ threadId: event.threadId, messageId }) | ||
| const existing = deps.requireThread(event.threadId).messages.find((message) => message.id === messageId) | ||
| deps.flushAssistantTextDelta({ threadId: eventThreadId, messageId }) | ||
| const existing = (eventThreadRecord?.thread || deps.requireThread(event.threadId)).messages.find((message) => message.id === messageId) |
There was a problem hiding this comment.
After flushAssistantTextDelta runs, the code still checks existing against eventThreadRecord?.thread, which was captured before the flush. When a turn emitted content.delta chunks, that flush can create/update the assistant message, but the stale pre-flush thread snapshot still appears empty and the fallback path appends event.payload.text again, duplicating the assistant response text. Re-fetch the thread state after flushing before deciding whether to append fallback text.
Useful? React with 👍 / 👎.
| ...nextQueuedMessage.options, | ||
| dispatchMode: 'immediate' | ||
| }) | ||
| if (cancelled) return |
There was a problem hiding this comment.
The drain coroutine bails out on if (cancelled) return, and cleanup sets cancelled = true whenever selectedSessionId changes. If a queued message send is in flight and the user switches sessions, a successful send for the previous session returns here without removing the queue head. When the user later returns, the same queued prompt is sent again. The queue item should still be reconciled/dequeued for the dispatched session even if selection changed mid-flight.
Useful? React with 👍 / 👎.
1 participant
Summary
Commits
efactor(assistant): modularize runtime, store, composer, and timeline flows
efactor(preview): split fullscreen preview workspace and markdown rendering
efactor(project-details): streamline git overview and progressive loading flows
Validation