fix(dashboard): frontend error handling from CodeRabbit review#83
Merged
justinjdev merged 2 commits intofeat/command-dashboardfrom Mar 21, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…parsing - Add Adversarial phase to PhaseTimeline.svelte phases array so progress bar renders correctly during adversarial review - Fix quests.ts to extract .quests array from eagles API response object instead of treating the whole response as the array Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ments - Await res.json() in all read helpers so JSON parse errors are caught by surrounding try/catch instead of escaping as unhandled rejections - Add synchronous (non-reactive) submitting guard in GateActions to prevent duplicate approve/reject submissions on rapid double-click - Restructure QuestCard to render gate action buttons as siblings of the clickable card link rather than nested inside it, fixing interactive element nesting. Also guard against empty worktree prop. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
justinjdev
force-pushed
the
worktree-fellowship-fix-frontend-errors
branch
from
27f6a0e to
89f51d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
res.json()in all 5 read helpers (fetchErrands, fetchTome, fetchAutopsies, fetchConfig, fetchCommands) so JSON parse errors are caught by surrounding try/catch instead of escaping as unhandled promise rejectionssubmittingguard in GateActions.svelte to prevent duplicate approve/reject submissions on rapid double-clickquest.worktreeTest plan
svelte-checkpasses (1 pre-existing error in unrelated file)vite buildsucceeds🤖 Generated with Claude Code