Skip to content

Conversation

@julianduque
Copy link
Contributor

Upgrade to NAN v2.0 API

@julianduque
Copy link
Contributor Author

Not sure why io.js v3.0.0 failed on travis, I was able to build it properly on my local install

@drewish
Copy link
Collaborator

drewish commented Aug 14, 2015

Looking at nan's example code I don't see any v8 includes. I wonder if we can just remove:

 #include <v8.h>
 #include <node.h>
 #include <node_object_wrap.h>
 #include <node_version.h>

And let NaN handle it? Curious if that would do anything about those errors.

@julianduque
Copy link
Contributor Author

@drewish still the same errors, weird I can't reproduce those locally

@drewish
Copy link
Collaborator

drewish commented Aug 18, 2015

Yeah looks like master is broken too. I'm going to play around with travis and see if I can get it building. If I can't figure something out pretty quickly I'll stop screwing around with it and just finish reviewing this. It seems like the broken build is independent of this.

@drewish
Copy link
Collaborator

drewish commented Aug 18, 2015

Okay yeah this all seems legit. I'll screw with Travis without bothering you ;)

Thanks for the contribution!

drewish added a commit that referenced this pull request Aug 18, 2015
@drewish drewish merged commit 87ccc13 into justinlatimer:master Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants