fix(mobile): unstick PWA orientation, add date range + slash-split cities#239
Merged
fix(mobile): unstick PWA orientation, add date range + slash-split cities#239
Conversation
…ties The PWA orientation fix in #238 only updated the manifest source. The service worker was caching `/manifest.webmanifest` cache-first, so Chrome's update probe kept seeing the old `orientation: portrait` value and installed PWAs stayed locked to portrait. Bump SW_VERSION to v7 to evict the stale runtime cache, and switch the manifest to network-first so future manifest changes propagate without another SW bump. While in the mobile trip header: - Surface the trip's date range next to the title (right-aligned, small + muted) so users can confirm they're looking at the right trip without scrolling into the day strip. - Use the slash separator and exclude the home bookend from the cities row — a SEA → Tokyo → Kyoto → SEA itinerary now reads as "Tokyo / Kyoto" rather than "Seattle · Tokyo · Kyoto". The bookend logic is shared with `primaryLocationFor` via a new `tripDestinationCities` helper in `@travel-app/shared`. https://claude.ai/code/session_01H5kv9m5n8eYqwnyGZzvgTW
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Slash reads as a transfer-day notation ("Paris / Rome" = travel from
one to the other on the same day) elsewhere in the app, so reusing
it for the trip-level cities row at the top of the mobile carousel
muddied the meaning. Middle-dot is the same separator the row used
before slash-split and matches the rest of the app's chip / pill
separators.
https://claude.ai/code/session_01H5kv9m5n8eYqwnyGZzvgTW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orientation: "portrait"to"any", but the service worker was caching/manifest.webmanifestcache-first. Chrome's update probe kept seeing the old portrait value, so installed PWAs never picked up the change. BumpSW_VERSIONtov7to evict the stale runtime cache, and switch the manifest to network-first so future manifest tweaks propagate without another SW bump.Tokyo / Kyotoinstead ofSeattle · Tokyo · Kyoto. The bookend logic is shared withprimaryLocationForvia a newtripDestinationCitieshelper in@travel-app/shared.Notes for installed PWAs
After this lands, existing PWA installs should rotate on next launch (the v7 SW activates → wipes the stale manifest → Chrome re-reads
orientation: "any"). iOS PWAs ignore the manifest'sorientationfield entirely — they already rotate by default unless device rotation is locked.Test plan
Tokyo / Kyotofor a SEA → Tokyo → Kyoto → SEA trip; reads asSeattlefor a Seattle-only staycation (bookend exclusion is dropped to avoid an empty row).pnpm testandpnpm lintpass.https://claude.ai/code/session_01H5kv9m5n8eYqwnyGZzvgTW
Generated by Claude Code