Conversation
Explicitly set `decoder->imageContentToDecode |= AVIF_IMAGE_CONTENT_GAIN_MAP` after creating the AVIF decoder in `CImageLoader`. This is required for `libavif` version 1.4.0 (and newer), where gain maps are no longer parsed or decoded by default unless requested via the `imageContentToDecode` field. Without this, attempting to apply tone mapping via `avifImageApplyGainMap` results in a crash due to missing gain map data.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes an access violation (0xC0000005) when opening some AVIF HDR files.
libavifversion 1.4.0 (used in this repository) deprecatedenableDecodingGainMapand introducedimageContentToDecode. This patch ensures the gain map is properly requested from the decoder so that tone mapping succeeds without crashing.PR created automatically by Jules for task 18097903921322488281 started by @justnullname