Refactor ImageLoader.cpp to remove dead code and redundancies#78
Conversation
- **Dead Code Elimination**: Removed `GetMetadataString` and `ExtractExifFromMemory` which were unreferenced. - **Deduplication**: Removed the overloaded `std::vector<uint8_t> ReadFileToVector(const std::wstring& path)` definition. All paths now use the standard `bool ReadFileToVector(LPCWSTR, std::vector<uint8_t>&)`. - **AST Consolidation**: Unified metadata parsing by consolidating `DecodeRational`, `DecodeSignedRational`, `GetMetadataRational`, and `GetMetadataSignedRational` into templated functions (`DecodeRationalT<bool>` and `GetMetadataRationalT<bool>`), reducing binary bloat and repetitive logic.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR implements a strict subtractive refactoring on
QuickView/ImageLoader.cppto eliminate codebase bloat without altering any outward behavior.GetMetadataString,ExtractExifFromMemory).ReadFileToVector(thestd::wstringoverload), ensuring the codebase consistently relies on the optimized, passed-by-referenceLPCWSTRversion.PR created automatically by Jules for task 2133924911928533632 started by @justnullname