fix: build.zig fallback version string not updated by bump-version workflow#341
Merged
fix: build.zig fallback version string not updated by bump-version workflow#341
Conversation
The bump-version workflow was updating build.zig.zon and npm/package.json but not build.zig's fallback version string. This caused drift when developers ran 'zig build' locally after a version bump. Fixes #314
yxlyx
pushed a commit
that referenced
this pull request
Mar 22, 2026
- Change build.zig sed from [0-9]*\.[0-9]*\.[0-9]* to [^"]* to match build.zig.zon and npm/package.json patterns - Add verification step to catch silent failures The old regex [0-9]*\.[0-9]*\.[0-9]* would fail silently on: - 4-part versions (0.0.26.1) - Pre-release versions (0.0.26-beta) Fixes #343 Refs #341
yxlyx
added
status:in-review
yxlyx
added a commit
that referenced
this pull request
Mar 22, 2026
- Change build.zig sed from [0-9]*\.[0-9]*\.[0-9]* to [^"]* to match build.zig.zon and npm/package.json patterns - Add verification step to catch silent failures The old regex [0-9]*\.[0-9]*\.[0-9]* would fail silently on: - 4-part versions (0.0.26.1) - Pre-release versions (0.0.26-beta) Fixes #343 Refs #341 Co-authored-by: Lim Yu Xi <limyuxi@Lims-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #314