Fix yxlyx compatibility and async xfail issues#118
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c335bcdcd8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| OAuth2PasswordBearer, | ||
| Security, | ||
| SecurityScopes, | ||
| verify_password, |
There was a problem hiding this comment.
Restore functional top-level verify_password export
Importing verify_password from security makes turboapi.verify_password always raise NotImplementedError, while hash_password is still exported from jwt_auth as a working implementation. This creates a regression for existing code that uses from turboapi import hash_password, verify_password to hash and then verify credentials, because verification now fails for all inputs at runtime instead of returning a boolean.
Useful? React with 👍 / 👎.
c335bcd to
d3fee0a
Compare
|
Addressed the Codex review comment. Update:
Re-validated after the change:
|
|
@yxlyx CI is green and the PR is ready. The Codex review comment was addressed in the latest update as well. |
Summary
turboapi.verify_passwordexport so it matchesturboapi.security.verify_passwordxfailmarkers that now pass on currentmainxfailTests
uv run --python 3.14t python -m pytest tests/test_async_handlers.py -p no:anchorpy -vuv run --python 3.14t python -m pytest tests/test_security_audit_fixes.py::test_top_level_verify_password_export_matches_security_module -p no:anchorpy --runxfail -vvuv run --python 3.14t python -m pytest tests/test_security_audit_fixes.py::test_get_password_hash_raises tests/test_fastapi_parity.py::TestSecurity::test_http_basic tests/test_fastapi_parity.py::TestAsyncHandlers::test_async_get_handler tests/test_fastapi_parity.py::TestAsyncHandlers::test_async_post_handler -p no:anchorpy -vTriage
turboapi.verify_passwordresolves to JWT helper instead ofturboapi.security.verify_password#116xfailmarkers on currentmain#117