Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b5240900c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| def test_release_version_bumped_past_bad_1_0_25_publish(): | ||
| """This release must move past the broken 1.0.25 artifact metadata.""" | ||
| assert _read_pyproject_version() == "1.0.26" |
There was a problem hiding this comment.
test_release_version_bumped_past_bad_1_0_25_publish now enforces an exact version string, so any valid future bump (for example to 1.0.27) will fail CI even when pyproject.toml, setup.py, and __init__.py stay correctly synchronized. This turns the regression test into a recurring manual gate unrelated to metadata drift; asserting the version is not 1.0.25 (or semver-greater) would preserve the intended protection without breaking future releases.
Useful? React with 👍 / 👎.
1 participant
Summary
1.0.25to1.0.26pyproject.toml,python/setup.py, andpython/turboapi/__init__.pyv1.0.26supersedes the badv1.0.25publishWhy
v1.0.25published assets labeled1.0.24, so this re-cuts the patch release on a fresh PR instead of tagging directly from a dirty/stale state.Tests
PYTHONPATH=/tmp/turboapi-release-126-pr/python /Users/rachpradhan/turboAPI/.venv/bin/python -m pytest tests/test_release_version_sync.py -qruff, TurboPG tests, Annotated Depends tests, security tests)