Skip to content

personal fixes for midi export#40

Draft
linux-leo wants to merge 1 commit into
juzzlin:masterfrom
linux-leo:master
Draft

personal fixes for midi export#40
linux-leo wants to merge 1 commit into
juzzlin:masterfrom
linux-leo:master

Conversation

@linux-leo
Copy link
Copy Markdown

@linux-leo linux-leo commented Apr 4, 2026

I made some changes until midi export worked the way I expected it to. These changes are probably a bit opinionated, but I figured they might still be useful to you for implementing export options. That's why I opened this as a draft PR. It also includes a fix for sending Note-Off Commands

@linux-leo linux-leo marked this pull request as draft April 4, 2026 14:50
@juzzlin
Copy link
Copy Markdown
Owner

juzzlin commented Apr 4, 2026

Thanks! I have been working on this in the big way so that PC and Bank can be optionally enabled in the export dialog. Also, Noteahead will try to match the port names on MIDI import and set programs and banks accordingly. And of course changed unit tests to match this.

@juzzlin
Copy link
Copy Markdown
Owner

juzzlin commented May 20, 2026

Does this work now in master like intended? :)

@linux-leo
Copy link
Copy Markdown
Author

linux-leo commented May 22, 2026

Almost! An Issue I still have is that percussion instruments aren't played on midi channel 10. IIRC the code skips over that channel when assigning tracks to channels. That's technically correct for melodic instruments but it doesn't allow me to have any percussion instruments on that channel. I see three options to solve this:

  1. play tracks on channel 10 if they're set as a drum track
  2. Auto assign tracks to channels except when the track specifies to be played on channel 10
  3. Don't auto assign tracks and play them on the same channels in the midi export as during live playback. (the channels specified in the tracks themselves)

Personally I prefer option 3 since it guarantees the midi export plays exactly how I hear it during live playback, but any of the three solutions would help.

@juzzlin
Copy link
Copy Markdown
Owner

juzzlin commented May 22, 2026

Thanks for your input! Could you create an Issue about this? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants