Skip to content

Staging/refactor codebase#53

Merged
jvspeed74 merged 5 commits intomainfrom
staging/refactor-codebase
Nov 14, 2024
Merged

Staging/refactor codebase#53
jvspeed74 merged 5 commits intomainfrom
staging/refactor-codebase

Conversation

@jvspeed74
Copy link
Copy Markdown
Owner

@jvspeed74 jvspeed74 commented Nov 14, 2024

This pull request includes several updates to the .editorconfig file, adjustments to GitHub Actions, and changes to the IntelliJ IDEA project configuration files. The most important changes include reducing the maximum line length, modifying PHP settings, and enhancing the continuous integration pipeline.

Updates to .editorconfig:

  • Reduced max_line_length from 120 to 88 characters to enforce stricter line length limits.
  • Removed specific settings for various file types such as .blade.php, .feature, .less, .sass, .scss, .twig, and .vue. [1] [2]

Enhancements to GitHub Actions:

  • Updated the continuous integration workflow to include additional log files and handle missing log files gracefully.

IntelliJ IDEA project configuration:

  • Added various new paths to the PHP include path and updated the PHPUnit settings to include paratest. [1] [2]
  • Enabled and configured additional inspections for PHP in the inspection profile.
  • Added targeted inspection scopes for PHPStan and PHP-CS-Fixer. [1] [2]

Coding standards and development documentation:

  • Updated DEV.md to include new Composer scripts for common tasks such as testing, fixing coding standards, and linting.
  • Removed the section on environment variables from DEV.md.

Signed-off-by: jvspeed74 <javaugh@iu.edu>
…ensive and confusing (#48)

* Disabled PHPStan and PHPCSFixer

* Set line length to 88

* .idea

* .idea

* Updated various composer packages to their most recent versioning -- most notably, `PHPStan`, which uses half the current memory due to recent optimizations.

* Specifically targeted directories with critical .php files with PHPStan instead of all .php files

* Trimmed unused editor config params

* Added targeted inspections for PHP-CS-Fixer

* Added PHPStan extension for strict rules

* Renamed composer.json scripts to be easier to remember and invoke

* Set path to PHP-CS-Fixer cache directory

Add to .gitignore

* Update DEV.md

* Renamed `composer phpstan` command to `composer lint`

Reduced phpstan level in phpstan.neon from max to 4

Temporarily disabled strict rules for phpstan
* Update PHP-CS-Fixer file cache path

* Strict enabled

Level 1 errors handled

* Level 2 errors handled

* Add stub files for better type hints with Eloquent Models

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* Add bootstrap.php file, separating the code from index.php

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* Level 3 PHPStan changes

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* Renamed `Builder.stub` to `EloquentBuilder.stub`

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* Removed getenv() function from db closure

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* PHPStan level 4

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* Formatted routes.php

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* Ignored an error where Slim4 devs  mistakenly excluded array as an acceptable type in routes.php

Increased phpstan.neon level to 5

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* Disabled rule that forced non-specialized types in subclass properties

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* PHPStan Level 7

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* PHPStan Level 8

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* PHPStan Max Level

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* Add todo and typing for `$casts` property

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* Moved bootstrap.php into config directory

Fixed mixed types in index.php

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* Renamed file

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* Adjusted type hints

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* Formatted file

Signed-off-by: jvspeed74 <javaugh@iu.edu>

* Cast `$definitions` to array

* Moved the php_server.log file into the logs directory and added a step to display the contents of both php_server.log and app.log. This ensures that both the PHP server logs and the application logs are captured and displayed.

* Point `php_server.log` to original path

* Rewrite routes from array to string

* Renamed stud

* Add default empty array value to $casts

* Added check to see if logs/app.log exists before running cat

---------

Signed-off-by: jvspeed74 <javaugh@iu.edu>
@jvspeed74 jvspeed74 linked an issue Nov 14, 2024 that may be closed by this pull request
5 tasks
@jvspeed74 jvspeed74 merged commit af1acc7 into main Nov 14, 2024
@jvspeed74 jvspeed74 deleted the staging/refactor-codebase branch November 14, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Codebase

1 participant