Skip to content

Only copy roomInfo if its valid and null check safety! #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

Only copy roomInfo if its valid and null check safety! #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Client/src/main/java/io/github/jwdeveloper/tiktok/TikTokLiveClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,14 +124,15 @@ public void tryConnect() {
tikTokEventHandler.publish(this, new TikTokConnectingEvent());
var userDataRequest = new LiveUserData.Request(roomInfo.getHostName());
var userData = httpClient.fetchLiveUserData(userDataRequest);
roomInfo.copy(userData.getRoomInfo());

if (userData.getUserStatus() == LiveUserData.UserStatus.Offline)
throw new TikTokLiveOfflineHostException("User is offline: " + roomInfo.getHostName(), userData, null);

if (userData.getUserStatus() == LiveUserData.UserStatus.NotFound)
throw new TikTokLiveUnknownHostException("User not found: " + roomInfo.getHostName(), userData, null);

roomInfo.copy(userData.getRoomInfo());

var liveDataRequest = new LiveData.Request(userData.getRoomInfo().getRoomId());
var liveData = httpClient.fetchLiveData(liveDataRequest);

Expand Down
1 change: 1 addition & 0 deletions Client/src/main/java/io/github/jwdeveloper/tiktok/TikTokRoomInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ public void updateRanking(List<RankingUser> rankingUsers) {

@Override
public void copy(LiveRoomInfo roomInfo) {
if (roomInfo == null) return;
this.roomId = roomInfo.getRoomId();
this.likesCount = roomInfo.getLikesCount();
this.viewersCount = roomInfo.getViewersCount();
Expand Down