Skip to content

Conversation

@JFronny
Copy link
Contributor

@JFronny JFronny commented Jan 12, 2025

To make the artifacts built by the GTK CI actually available to users, they need to be downloadable from somewhere.
I had intended GitHub Releases to be that place, but it seems like you didn't enable publishing to it the last time you ran the action (the option to do so was intended for testing, since Actions artifacts get deleted after some time and need login to access, but potentially broken builds shouldn't be released).
With this change, the corresponding checkbox is checked by default, which better represents the intended use.

@jwharm jwharm merged commit 88fea8b into jwharm:main Jan 13, 2025
@jwharm
Copy link
Owner

jwharm commented Jan 13, 2025

Thanks!

@JFronny JFronny deleted the ci-release-default branch January 13, 2025 20:30
@JFronny
Copy link
Contributor Author

JFronny commented Jan 13, 2025

Looking at the build log, it seems like my libadwaita patch did not apply in Actions.
The same patch worked without issue on the same versions when I ran it on Actions before submitting it, so I find this very surprising.
I'll try to figure out what is wrong here as soon as I am able (probably in three days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants