Prepare to make ProxyInstance.address field private again #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The address of a java-gi proxy class must be accessed with the `handle()` method (as specified in the Proxy interface). The actual address is stored in the `address` field of the ProxyInstance class. That field had private visibility until java-gi 0.12, when it was changed to public visibility. I want to revert that, so it is now marked as deprecated, and will be changed to private visibility in a future release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The address of a java-gi proxy class must be accessed with the
handle()method (as specified in the Proxy interface). The actual address is stored in theaddressfield of the ProxyInstance class. That field had private visibility until java-gi 0.12, when it was changed to public visibility. I want to revert that, so it is now marked as deprecated, and will be changed to private visibility in a future release.