Conversation
- replaced JetBrains Annotations with JSpecify - set `Nullable` annotation on generated method parameters and return values that are explicitly marked as nullable in the gir - remove `NotNull` annotations for now - Update several java-gi core classes to be NullMarked
Separated null checks from null annotations; Pointers are not nullable by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152
All bindings generated by Java-GI are now annotated as
@NullMarkedon the module level (inmodule-info.java). The parameters and return values that are nullable, are annotated as@Nullable.This should improve the usability of the generated API with null-safe languages like Kotlin.