Delete common/src/main/java/io/github/jy95/fds/common/functions/Forma…

[jy95]

…tDateTimes.java

Summary by CodeRabbit

• Revert
  • Removed the public date-time formatting interface. Applications relying on this functionality will need to implement formatting directly or use alternative solutions.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The public interface FormatDateTimes<T> has been removed from the common functions package. This interface previously provided single-item and bulk date-time formatting capabilities via its required convert(Locale, T) method and default bulk conversion helper.

Changes

Cohort / File(s)	Summary
Interface Removal common/src/main/java/io/github/jy95/fds/common/functions/FormatDateTimes.java	Removed public generic interface FormatDateTimes<T> and its methods: required String convert(Locale locale, T date) and default List<String> convert(Locale locale, List<T> dates)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

This is a straightforward removal of a single interface definition with no complex logic or widespread dependencies visible in the diff. The main review focus would be:

• Verify this interface is not actively used elsewhere in the codebase
• Confirm callers have been migrated or removed appropriately

Poem

🐰 An interface once lived in functions so fine,
With date-time conversions, all perfectly aligned,
But alas, it's now gone—retired with care,
The rabbit sends it off on the digital air! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the primary change: deletion of the FormatDateTimes.java file from the repository.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch jy95-patch-1

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 64551f5 and 02ca617.

📒 Files selected for processing (1)

• common/src/main/java/io/github/jy95/fds/common/functions/FormatDateTimes.java (0 hunks)

💤 Files with no reviewable changes (1)

• common/src/main/java/io/github/jy95/fds/common/functions/FormatDateTimes.java

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Analyze (java-kotlin)
• GitHub Check: submit-pypi

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.26% (target: -1.00%)	✅ ∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (64551f5)	1567	1563	99.74%
Head commit (02ca617)	3126 (+1559)	3126 (+1563)	100.00% (+0.26%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#263)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences