Conversation
Owner
k-kohey
commented
Feb 26, 2026
k-kohey
commented
- Add comprehensive tests for thunk generation edge cases and known bugs
- Refactor and enhance tests for thunk generation and known bugs
- Introduced new test files to cover various edge cases and limitations in thunk generation, including async methods, throwing methods, and deeply nested types. - Added tests for known bugs in thunk generation, ensuring that issues are documented and can be tracked for resolution. - Created tests for macro and property wrapper handling, verifying that thunks are generated correctly for SwiftUI features. - Implemented multi-file interaction tests to address scenarios with name collisions and dependencies across files. - Documented architectural limitations and design challenges in a new markdown file for future reference and improvement efforts.
- Updated test cases in `thunk_compile_known_bugs_test.go` to reflect fixes for method inclusion and argument handling in thunks. - Moved existing tests from `thunk_compile_multifile_test.go` and `thunk_compile_multifile2_test.go` to consolidate known bug tests. - Improved error messages in tests to provide clearer feedback on expected behavior. - Added normalization logic for method names in the parser to address discrepancies between selector and base names. - Enhanced handling of property wrappers in preview transformations to ensure compatibility with SwiftUI features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.