Router interface: reconcile interfaces for routers pending deletion#423
Merged
mandre merged 3 commits intok-orc:mainfrom Jun 2, 2025
Merged
Router interface: reconcile interfaces for routers pending deletion#423mandre merged 3 commits intok-orc:mainfrom
mandre merged 3 commits intok-orc:mainfrom
Conversation
In order to bring more consistency across tests.
Use a consistent name for the router interface controller. It appeared as `routerinterface` or `router_interface` in the logs, depending on the event generating the log.
This hopefully fixes a deadlock situation where an unmanaged router is not available due to the backing router being deleted in OpenStack, causing the router interface to not reconcile, and preventing the router deletion due to pending finalizer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hopefully fixes a deadlock situation where an unmanaged router is not
available due to the backing router being deleted in OpenStack, causing
the router interface to not reconcile, and preventing the router
deletion due to pending finalizer.
While I was looking at router interface, I also made the object names more consistent with other tests in the
routerinterface-create-minimaltest, and used a consistent name for logging, as it appeared asrouterinterfaceorrouter_interfacein the logs, depending on the event generating the log.Fixes #378.