Fix actuator errors going silently #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the quick fix. Have you scanned the code to see if that was the only place where we returned nil instead of a progress.ReconcileStatus? |
Router and floating ip controller panics due to any client error in newActuator due to errors not bubbling up. Add proper error handling to avoid panics. fixes: k-orc#587
Contributor
Author
|
Scanned now, same issue exist in the floatingIP actuator adding it to the patch. |
eshulman2
changed the title
mandre
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Router and floating ip controller panics due to any client error in
newActuator due to errors not bubbling up. Add proper error handling to
avoid panics.
fixes: #587