[release-2.0] Use IsRetryable instead of IsConflict for terminal errors#778
Merged
Conversation
Rewrite orcerrors.IsRetryable and replace all uses of orcerrors.IsConflict with !orcerrors.IsRetryable when classifying errors as terminal in create and update paths. IsConflict only caught HTTP 409 responses, but non-HTTP errors from gophercloud (e.g. client-side validation such as banned value_spec keys) would cause infinite retries. The rewritten IsRetryable returns true for more errors that may succeed when retried without changes to the spec: - HTTP error responses other than 409 are retryable (some 4xx errors like 400 Bad Request can be transient, e.g. when a dependency is not yet ready in OpenStack) - HTTP 409 Conflict is not retryable - Non-HTTP errors from gophercloud are not retryable The check is now nested inside an `if err != nil` guard for clarity and safety, matching the pattern already used in CreateResource paths. Also add godoc comments to all public functions in the errors package. Closes #241
mandre
approved these changes
May 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Collaborator
|
Github hiccup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #771
Rewrite
orcerrors.IsRetryableand replace all uses oforcerrors.IsConflictwith!orcerrors.IsRetryablewhen classifying errors as terminal in create and update paths.IsConflictonly caught HTTP 409 responses, but non-HTTP errors from gophercloud (e.g. client-side validation such as banned value_spec keys) would cause infinite retries.The rewritten
IsRetryablereturnstruefor more errors that may succeed when retried without changes to the spec:The check is now nested inside an
if err != nilguard for clarity and safety, matching the pattern already used inCreateResourcepaths.Also add godoc comments to all public functions in the errors package.
Closes #241