OS resolver missing os-release file fallback / guess#313
Merged
Conversation
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
There was a problem hiding this comment.
Pull request overview
Adds a Linux OS-release resolver fallback for environments where /etc/os-release and /usr/lib/os-release are missing, by probing for known package manager binaries and synthesizing an *os.Release.
Changes:
- Added
ResolveLinuxCompatresolver that guesses distro/family based on detected package manager binaries. - Added
RegisterLinuxCompathelper to register the compat resolver. - Registered
ResolveLinuxCompatin the default OS resolver registry afterResolveLinux.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| os/linux_compat.go | Introduces the Linux “compatibility mode” resolver that probes package managers and synthesizes a Release. |
| os/defaultprovider.go | Registers the new compat resolver in the default resolver chain. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an
os-releasefile is not found, try to guess based on an installed package manager.