remotefs.OS Chown, Touch, DownloadURL, FileContains, IsContainer#318
Conversation
There was a problem hiding this comment.
Pull request overview
Adds several last-mile remotefs.OS API additions/changes for rig v2 to support richer remote filesystem operations across POSIX and Windows implementations.
Changes:
- Change
OS.Chownto accept anownerstring (e.g.,user:group) instead of numeric uid/gid. - Extend
OS.Touchto accept an optional timestamp, and addDownloadURL,FileContains, andIsContainertoremotefs.OS. - Update Windows/POSIX FS implementations and the
upload_teststub to satisfy the expanded interface; add repo-level context inCLAUDE.md.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
remotefs/winfs.go |
Updates Touch signature; adds DownloadURL, FileContains, IsContainer; adjusts Chown signature. |
remotefs/posixfs.go |
Updates Touch and Chown signatures; adds DownloadURL, FileContains, IsContainer; introduces errNoDownloadTool. |
remotefs/types.go |
Extends remotefs.OS interface with new methods and signature changes. |
remotefs/upload_test.go |
Updates the uploadFS stub to satisfy the new remotefs.OS interface. |
CLAUDE.md |
Adds repository/v2 architecture and migration notes including the new remotefs.OS API surface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kke
force-pushed
the
remotefs-os-additions
branch
from
90126f6 to
b7a06de
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kke
force-pushed
the
remotefs-os-additions
branch
from
c42438e to
f442e56
Compare
kke
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kke
force-pushed
the
remotefs-os-additions
branch
from
f442e56 to
382355c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kke
force-pushed
the
remotefs-os-additions
branch
from
382355c to
2256237
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kke
force-pushed
the
remotefs-os-additions
branch
from
2256237 to
1c53fb4
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…leContains, IsContainer Part of the rig v2 last-mile effort, breaking API is not an issue, v2 has not been released yet. Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
force-pushed
the
remotefs-os-additions
branch
from
1c53fb4 to
f185b1d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Part of the rig v2 last-mile effort, breaking API is not an issue, v2 has not been released yet.