[release-0.x] Fix Windows sudo detection to use IsInRole for effective elevation check#338
Merged
kke merged 3 commits intorelease-0.xfrom May 7, 2026
Merged
Conversation
…e elevation check Replace the three-step heuristic (whoami username check, net user Administrators group check, EnableLUA registry query) with a single PowerShell IsInRole call. WindowsPrincipal.IsInRole uses CheckTokenMembership and returns true only when the Administrators SID is present and not marked deny-only — the correct signal for an effectively elevated session. This handles SSH sessions (Windows OpenSSH always provides a full elevated token for Administrators group members, regardless of UAC), WinRM domain accounts, and local accounts with LocalAccountTokenFilterPolicy=1. Also updates the error message to accurately reflect what was detected. Fixes #332 Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
There was a problem hiding this comment.
Pull request overview
This PR updates Windows sudo detection in Connection.discoverSudo() by replacing a multi-step UAC/username/group-membership heuristic with a single PowerShell WindowsPrincipal.IsInRole(Administrator) check, aiming to correctly detect effective elevation for sessions such as OpenSSH/WinRM and avoid false “sudo required” failures.
Changes:
- Replace Windows admin/elevation detection heuristic with an
IsInRole-based privilege check. - Update the Windows
ErrSudoRequiredmessage to reflect missing administrator privileges for the current session.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the three-step heuristic (whoami username check, net user Administrators group check, EnableLUA registry query) with a single PowerShell IsInRole call. WindowsPrincipal.IsInRole uses CheckTokenMembership and returns true only when the Administrators SID is present and not marked deny-only — the correct signal for an effectively elevated session. This handles SSH sessions (Windows OpenSSH always provides a full elevated token for Administrators group members, regardless of UAC), WinRM domain accounts, and local accounts with LocalAccountTokenFilterPolicy=1. Also updates the error message to accurately reflect what was detected.
Fixes #332