Fix Windows sudo detection to use IsInRole for effective elevation check#339
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Windows “sudo/no-op” capability detection to rely on an effective-elevation check (WindowsPrincipal.IsInRole(Administrator)) rather than inspecting token group SIDs directly, addressing false positives/negatives in UAC-filtered WinRM/local sessions and Windows OpenSSH sessions (per #332).
Changes:
- Replace the token
.Groups -contains BuiltinAdministratorsSidcheck (andwhoamiheuristic) with a PowerShellWindowsPrincipal.IsInRole(Administrator)check. - Update the function comment to describe the new elevation semantics and rationale.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replace the raw token Groups SID check with WindowsPrincipal.IsInRole, which calls CheckTokenMembership and returns true only when the Administrators SID is present and not marked deny-only. This correctly handles SSH sessions (Windows OpenSSH always provides a full elevated token for Administrators group members, regardless of UAC) as well as WinRM domain accounts and local accounts with LocalAccountTokenFilterPolicy=1. The previous Groups check could also produce false positives for WinRM local accounts with filtered tokens, where the Administrators SID is present but deny-only. Fixes #332 Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
force-pushed
the
fix/windows-sudo-elevation
branch
from
0c72e35 to
efe2c84
Compare
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the raw token Groups SID check with WindowsPrincipal.IsInRole, which calls CheckTokenMembership and returns true only when the Administrators SID is present and not marked deny-only. This correctly handles SSH sessions (Windows OpenSSH always provides a full elevated token for Administrators group members, regardless of UAC) as well as WinRM domain accounts and local accounts with LocalAccountTokenFilterPolicy=1. The previous Groups check could also produce false positives for WinRM local accounts with filtered tokens, where the Administrators SID is present but deny-only.
Fixes #332