Conversation
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
There was a problem hiding this comment.
Pull request overview
This PR updates several remote command invocations to “dogfood” the internal sh package for safer/cleaner command construction instead of manual fmt.Sprintf(...) + shell-escaping.
Changes:
- Replaced several
fmt.Sprintf(...)-built commands inPosixFSwithsh.Command(...)(e.g.,chmod,install,mkdir,printenv). - Reworked
PosixFileddcalls to usesh.Command(...)rather than formatting a single shell string. - Updated Upstart “disable service” to write the override file using
teewith stdin instead of shell redirection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
remotefs/posixfs.go |
Migrates multiple filesystem operations to sh.Command(...) and changes Getenv to printenv. |
remotefs/posixfile.go |
Migrates dd-based read/write/copy operations to sh.Command(...). |
initsystem/upstart.go |
Removes manual shell escaping and writes override files via tee + stdin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were several places there rig didn't "dogfood" on the
shpackage for building commands.