Conversation
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
added
dependencies
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
There was a problem hiding this comment.
Pull request overview
Adds vulnerability scanning to the Go CI pipeline by introducing a govulncheck job, and updates the Go toolchain/dependencies to address existing vulnerability warnings.
Changes:
- Add a new GitHub Actions job to run
govulncheckafter unit tests. - Bump
toolchaintogo1.26.3. - Update dependencies (
golang.org/x/netandgithub.com/masterzen/winrm) and refreshgo.sumaccordingly.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
go.mod |
Updates Go toolchain version and bumps indirect dependency (golang.org/x/net). |
go.sum |
Updates module checksums for the dependency bumps. |
.github/workflows/go.yml |
Adds a govulncheck CI job that runs after unit tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs govulncheck as a step in the github workflow.
Also updates go toolchain to 1.26.3 and x/net to 0.55.0 to get rid of active warnings.