chore: fix lint errors and fix reviewdog/action-golangci-lint#229
Merged
k1LoW merged 7 commits intok1LoW:mainfrom Jul 10, 2025
Songmu:lint
Merged
chore: fix lint errors and fix reviewdog/action-golangci-lint#229k1LoW merged 7 commits intok1LoW:mainfrom Songmu:lint
k1LoW merged 7 commits intok1LoW:mainfrom
Songmu:lint
Conversation
…be 0600 or less (gosec)
…ns to be 0600 or less (gosec)
…punctuation or newlines (staticcheck)
…th punctuation or newlines (staticcheck)
…cated fail_on_error
Owner
|
🙏 🙏 🙏 Thank you!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After running make lint, I found some errors and fixed them. Most of them were caused by me. I'm sorry for them.
It seems that reviewdog was not working properly, so I fixed that as well. I am not sure if it will work correctly, but I changed the old, deprecated settings to new ones and disabled caching because there were errors in the cache processing.