fix: correct handling of ignore outside in non-watch mode.#378
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of ignore fields in markdown content when running in non-watch mode, ensuring that content marked with ignore: true is properly filtered out before processing.
- Adds filtering logic to exclude ignored content in the apply command
- Replaces direct assignment of
m.Contentswith filtered content processing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Code Metrics Report
Details | | main (35e9aff) | #378 (23697ec) | +/- |
|---------------------|----------------|----------------|-------|
- | Coverage | 31.8% | 31.7% | -0.1% |
| Files | 26 | 26 | 0 |
| Lines | 3050 | 3054 | +4 |
| Covered | 971 | 971 | 0 |
- | Code to Test Ratio | 1:0.8 | 1:0.8 | -0.1 |
| Code | 6264 | 6270 | +6 |
| Test | 5464 | 5464 | 0 |
+ | Test Execution Time | 11s | 10s | -1s |Code coverage of files in pull request scope (20.1% → 19.6%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #349
SSIA.