Skip to content

fix: correct handling of ignore outside in non-watch mode.#378

Merged
k1LoW merged 2 commits intomainfrom
fix-ignore
Aug 19, 2025
Merged

fix: correct handling of ignore outside in non-watch mode.#378
k1LoW merged 2 commits intomainfrom
fix-ignore

Conversation

@k1LoW
Copy link
Owner

@k1LoW k1LoW commented Aug 19, 2025

ref: #349

SSIA.

@k1LoW k1LoW self-assigned this Aug 19, 2025
@k1LoW k1LoW added the bug Something isn't working label Aug 19, 2025
@github-actions

This comment has been minimized.

@k1LoW k1LoW requested a review from Copilot August 19, 2025 11:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the handling of ignore fields in markdown content when running in non-watch mode, ensuring that content marked with ignore: true is properly filtered out before processing.

  • Adds filtering logic to exclude ignored content in the apply command
  • Replaces direct assignment of m.Contents with filtered content processing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link
Contributor

Code Metrics Report

main (35e9aff) #378 (23697ec) +/-
Coverage 31.8% 31.7% -0.1%
Code to Test Ratio 1:0.8 1:0.8 -0.1
Test Execution Time 11s 10s -1s
Details
  |                     | main (35e9aff) | #378 (23697ec) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          31.8% |          31.7% | -0.1% |
  |   Files             |             26 |             26 |     0 |
  |   Lines             |           3050 |           3054 |    +4 |
  |   Covered           |            971 |            971 |     0 |
- | Code to Test Ratio  |          1:0.8 |          1:0.8 |  -0.1 |
  |   Code              |           6264 |           6270 |    +6 |
  |   Test              |           5464 |           5464 |     0 |
+ | Test Execution Time |            11s |            10s |   -1s |

Code coverage of files in pull request scope (20.1% → 19.6%)

Files Coverage +/- Status
cmd/apply.go 19.6% -0.5% modified

Reported by octocov

@k1LoW k1LoW merged commit 7deb5b4 into main Aug 19, 2025
1 check passed
@k1LoW k1LoW deleted the fix-ignore branch August 19, 2025 12:35
@github-actions github-actions bot mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants