fix: handle atomic saves and improve live-reload reliability#54
Merged
Conversation
- Watch for Create/Remove/Rename events in addition to Write to support editors using atomic save (write-to-temp + rename) - Re-add file watcher after rename/remove to maintain watch on new inode - Remove files from list when actually deleted (not just atomic-saved) - Add exponential backoff to SSE reconnection (1s to 30s cap) - Increase SSE subscriber channel buffer from 4 to 16 - Log warnings for watcher errors and dropped SSE events
Contributor
Code Metrics Report
Details | | main (8480f78) | #54 (378509f) | +/- |
|---------------------|----------------|---------------|-------|
- | Coverage | 39.7% | 39.3% | -0.4% |
| Files | 27 | 27 | 0 |
| Lines | 2653 | 2678 | +25 |
| Covered | 1054 | 1054 | 0 |
- | Code to Test Ratio | 1:0.4 | 1:0.4 | -0.1 |
| Code | 3072 | 3100 | +28 |
| Test | 1460 | 1460 | 0 |
- | Test Execution Time | 32s | 33s | +1s |Code coverage of files in pull request scope (26.0% → 24.9%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create/Remove/Renamefsnotify events in addition toWriteto support editors using atomic save (write-to-temp + rename pattern used by Vim, VS Code, etc.)useSSE.ts