Replies: 2 comments 1 reply
Are you able to fully understand the code you plan to contribute, and are you comfortable making changes during the code review process? |
1 reply
|
Since the PR exists now (#2945) I'll close this thread. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Hello, I've been working on adding token level timestamp support for whisper models. It is working well locally but I have a few questions I'd like to pose before submitting a PR.
cross_attention_weightsto the output, and existing published csukuangfj/sherpa-onnx-whisper-* models will not be able to support timestamps. Is this a big enough problem that you would decline the PR?My branch currently outputs not only token-level timestamps, but also words and word-level timestamps (because timing.py supports this). Would the word-level output be worth keeping, or should I remove it so whisper output looks the same as other models?Update: I studied the word boundary logic and it is totally downstream of token timestamps, so I removed it--it is useful but should not be tied to any one model family.Thank you for this great library!
All reactions